Open
Conversation
Owner
davidferguson
left a comment
davidferguson
left a comment
There was a problem hiding this comment.
It's currently broken with an easy fix (that I've suggested in this PR for you), and we need to strip out relaxed screening from titles (and maybe make an attribute too).
| attributes['event'] = True | ||
| film_name = film_name.replace('national theatre live: ', '') | ||
| # remove all the ignore items from the film name | ||
| for ignore_item in FILM_NAME_IGNORES: |
Owner
There was a problem hiding this comment.
FILM_NAME_IGNORES is empty, what is the purpose of this check?
| # convert to lowercase for easier processing | ||
| film_name = film_name.lower() | ||
| # check to see if this is a live event | ||
| if film_name.startswith('national theatre live: '): |
Owner
There was a problem hiding this comment.
It looks like Birks also does relaxed screenings (eg. for White Christmas) - good to have this as an attribute maybe? Or at least strip it out of the title.
Comment on lines
+90
to
+93
| showings_divs = soup.select('div[x-show="tab === \'dates\'"]') | ||
| if len(showings_divs) != 1: | ||
| raise CinemaArchiverException(f'Expected a single showings div, found {len(showings_divs)}') | ||
| showings_div = showings_divs[0] |
Owner
There was a problem hiding this comment.
Suggested change
| showings_divs = soup.select('div[x-show="tab === \'dates\'"]') | |
| if len(showings_divs) != 1: | |
| raise CinemaArchiverException(f'Expected a single showings div, found {len(showings_divs)}') | |
| showings_div = showings_divs[0] | |
| showings_div = soup.find('div', {'id': 'tab-dates'}) |
Birks have obviously updated their HTML slightly, and now the tab has an id of tab-dates. The suggested change above fixes this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Birks Cinema to the archiver. This is a local, independent cinema that exposes little information beyond the film name and year, although whether or not a showing is a live event or not can sometimes be determined from the showing title.