Skip to content

Fix picturehouse sub/dub attributes#29

Open
davidferguson wants to merge 3 commits intomasterfrom
fix-picturehouse-subdub
Open

Fix picturehouse sub/dub attributes#29
davidferguson wants to merge 3 commits intomasterfrom
fix-picturehouse-subdub

Conversation

@davidferguson
Copy link
Copy Markdown
Owner

  • Add the subtitle language for showings, when it can be worked out.
  • When a film is dubbed, add the dubbed language to the language attribute, if it can be worked out
  • Add a kids attribute for the Kids Club (where adults must be accompanying a child)

Copy link
Copy Markdown
Collaborator

@andrewferguson andrewferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, we need to figure out how granular we want to be with children-only showings (Picturehouse has Watch with Baby, Toddler Time, and Kids showings).

Secondly, there are a number of missing attributes:

There is also Screen Arts which is the category for some live theatre events, along with NT Live and RSC. (The latter two may have been superseded by "Screen Arts").

Adding all these attributes in would seem like a sensible idea.

Another issue is that some non-cinema events are being saved. The one I noticed is The Big Ritzy Quiz. I'm not sure what the best way of handling this is, if it is even possible.

Comment on lines 137 to 138
elif attribute['attribute'] == 'Toddler Ti':
json_attributes['carers-and-babies'] = True
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated. Picturehouse has both a Watch with Baby and a Toddler Time category (in addition to the Kids' Club).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants