fix vista_systems (odeon and curzon) updating API#31
Open
davidferguson wants to merge 1 commit intomasterfrom
Open
fix vista_systems (odeon and curzon) updating API#31davidferguson wants to merge 1 commit intomasterfrom
davidferguson wants to merge 1 commit intomasterfrom
Conversation
andrewferguson
added
the
hacktoberfest-accepted
Collaborator
andrewferguson
left a comment
andrewferguson
left a comment
There was a problem hiding this comment.
This PR has fixed the issue with the changes to the API. Aside from my one concern about a possible place that could easily crash, this looks OK.
Comment on lines
+119
to
+121
| for site in sites_data['sites']: | ||
| site_query += SHOWINGS_SITE_QUERY.format(site_id=site['id']) | ||
| return site_query[:-1] |
Collaborator
There was a problem hiding this comment.
My concern here is that if there are no sites, then site_query will be empty, so attempting to access site_query[:-1] will fail. Is this something we want to account for, or is that error acceptable as a sign of a change in the API?
Owner
Author
There was a problem hiding this comment.
I think it's an acceptable error - no cinema will have no sites (unless it's shut).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vista Systems has undergone a API change, breaking Odeon and Curzon. This PR updates the archiver for Vista to accommodate this change.