fix: improve instance wake/provision error quality#198
Open
bmdavis419 wants to merge 1 commit intocodex/pr-g-windows-path-hardeningfrom
Open
fix: improve instance wake/provision error quality#198bmdavis419 wants to merge 1 commit intocodex/pr-g-windows-path-hardeningfrom
bmdavis419 wants to merge 1 commit intocodex/pr-g-windows-path-hardeningfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issues
Greptile Summary
This PR improves error diagnostics and reliability for instance wake/provision operations. Key changes include adding retry logic for btca server starts (up to 2 attempts with process cleanup between retries), optional git authentication configuration via
BTCA_GIT_TOKENenv var, and enhanced error messages that include health check attempts/status and log tail output for easier debugging.Key Changes:
startBtcaServerWithRetry()function that retries server start up to 2 times with pkill cleanup between attemptsconfigureSandboxGitAuth()to configure git credentials in sandbox (optional, requiresBTCA_GIT_TOKENenv var)configure_git_authstep label for better error contextNo breaking changes detected. All new functionality is additive and properly wrapped in error handling.
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: aec0baf