Add LightVAE support #221
Open
Add LightVAE support #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Fix v2v streaming choppiness when using fast VAEs (LightVAE/TAE) by basing frame consumption rate on measured input FPS rather than pipeline production throughput. This fix is required to introduce faster VAEs and likely other performance enhancements. ## Problem LightVAE and TAE produced choppy playback during v2v streaming, where the boundaries of the chunks are visible. The slower Wan VAE worked perfectly. Symptoms: - Choppiness only with fast VAEs - Test scripts produced smooth output - Choppiness went away after ~45 seconds or when using more denoise steps - Choppiness _sometimes_ went away upon updating the prompt - Lightvae and Wan vae are virtually identical apart from processing speed. Tae is faster still ## Root Cause The frame consumption rate (how fast WebRTC sends frames to the client) was calculated from **production throughput** (how fast the GPU produces frames) rather than **content temporal rate** (how fast frames should be played). Eg, when a fast VAE produces 12 frames in 0.3s, the code calculated FPS=40 and sent frames to the client at 40fps. But the video content should maintain its original temporal rate for correct motion - playing it faster causes choppy/jerky appearance. The test scripts worked because they export with a fixed FPS value, not the production rate. ## Solution Measure the actual input video frame rate by tracking timestamps of incoming frames, then use that rate for consumption: - Track timestamps of last 30 incoming frames in `input_loop()` - Calculate input FPS from frame intervals - Use input FPS when available (>=5 samples) - Fall back to existing pipeline FPS calculation otherwise (for t2v mode or during warm-up) ## Tested - [x] no regression with Wan VAE Signed-off-by: RyanOnTheInside <7623207+ryanontheinside@users.noreply.github.com>
Signed-off-by: RyanOnTheInside <7623207+ryanontheinside@users.noreply.github.com>
Open
…t, pipeline) for output rate Signed-off-by: RyanOnTheInside <7623207+ryanontheinside@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase after merging #219