Open
Conversation
8 tasks
Collaborator
Author
|
@sssangha can you verify that the comment change I made in the losreader file is correct? I.e. that the direction is ccw from east, not cw from north. |
Collaborator
Author
|
Pinging @sssangha on this. Thanks! |
Owner
|
@jlmaurer can this be closed? |
Collaborator
Author
|
@dbekaert I'm still not sure which convention for heading is actually correct. The dev branch still says cw from north, but not sure if that is actually the right one. If so then yes can be closed, if not we should just update the comment. |
Owner
|
Can we not check isce3 documentation? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description