Cancellable get results

[PhakornKiong]

Resolves #85

[PhakornKiong]

@maxdml I'm unable to get to this code path, so not sure if we really need it.

Tried shutting down DBOS server, but it get DB error from h.outcomeChan instead.

Let me know your thoughts

[maxdml]

For this path to kick in, you need to manually Launch and Shutdown the DBOSContext in a test. The sequence would be:

• Launch
• Run blocking workflow (so that the function doesn't return and its result never reaches outcomeChan)
• GetResult with no timeout
• Shutdown DBOSContext
• GetResult should result the error (which should be a context.Context DeadlineExceeded error)

[maxdml]

For this to work, the workflow must signal that it started, which you can achieve by using the test utilities "event" API. See an example here.

[PhakornKiong]

For this case, should it be context.Canceled instead?

[maxdml]

You mean for a test exercising case <-h.dbosContext.Done(): ? You're right, it depends on how the context is cancelled (manually or through a deadline)

[maxdml]

Thanks @PhakornKiong . Left a few comments. Let me know if you have more questions!

[maxdml]

For this path to kick in, you need to manually Launch and Shutdown the DBOSContext in a test. The sequence would be:

• Launch
• Run blocking workflow (so that the function doesn't return and its result never reaches outcomeChan)
• GetResult with no timeout
• Shutdown DBOSContext
• GetResult should result the error (which should be a context.Context DeadlineExceeded error)

[maxdml]

For this to work, the workflow must signal that it started, which you can achieve by using the test utilities "event" API. See an example here.

[PhakornKiong]

@maxdml Noticed that there are test like TestEnqueue/EnqueueWithTimeout that fails, is it a flaky test?

I tired running on local as well as on my forked repo and it went fine.

Let me know if there are any other changes that i should make

[maxdml]

Thanks @PhakornKiong