Add format DATEw. #83
Conversation
There was a problem hiding this comment.
Chen: A POSIXt is an R datetime stamp. It has a date component. I think you can format with your DATEw formats also. You can test it with Sys.time(). If you convert to a date first like this as.Date(Sys.time()) then you can format just like the Date class. For test cases, you can use as.POSIXct() and pass a text string.
dbosak01
left a comment
dbosak01
left a comment
There was a problem hiding this comment.
Also add documentation to the "Formatting Strings" section of fmtr.R. There is already a section there concerning dates. Maybe you can add after that. Make it different than the documentation for fapply(). It helps to explain things in different ways.
dbosak01
left a comment
dbosak01
left a comment
There was a problem hiding this comment.
Overall, great job. I like it a lot. I think we should do the SAS time formatting next.
|
MacOS action is broken. Not your fault. I'll review anyway. |
2 participants
Add DATEw. format to replicate SAS format DATEw. , fixing #77
Also, the test cases and documentation of DATEw. are added.