-
Notifications
You must be signed in to change notification settings - Fork 62
Isolating distribution testing #910
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v4 | ||
| uses: actions/setup-python@v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repo is behind on some of the versions of Actions that are updated in the other repos. I figured I would update them while changing this file to match what we have everywhere else. The run still passes without issues on the upgrade
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-22.04, macos-12, windows-2022] | ||
| os: [ubuntu-latest, macos-12, windows-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, I remember wanting to keep on the latest images (this isn't the case for Mac, not sure why). So the other adapter repos use latest instead of a hard coded version so updating this to keep parity as well. I can revert this if it isn't wanted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We determined that it's better to hard pin and then upgrade as we can. The primary issue is that the latest tag eventually bumps and the new image may not have all of the python versions installed. We ran into this on macos in particular, which is probably what we used to pin that in the past.
|
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
resolves dbt-labs/dbt-adapters#632
Problem
We validate wheel and source distributions in the same environment during the build validation step. This led to issues documented here dbt-labs/dbt-core#10465.
Solution
This is the same solution as what we did in
dbt-snowflakefirst: dbt-labs/dbt-snowflake#1161This is to bring parity to the other repos as well.
This is a test run of the Action running with the installation and testing of wheels and source distributions split into separate Actions Jobs that isolate them from one another: https://github.com/leahwicz/dbt-redshift/actions/runs/10821351505
Checklist