Clipping Buffers to jurisdictional boundaries#131
Merged
Conversation
…, this needs to be different from the ones we display because Fairfax City and Falls Church do not have seperate bike infrastructure files.
…urisdictional boundaries.
…t doesn't error with an out of memory exception.
Collaborator
Author
|
PR #132 includes everything in this PR + adds more stringent data filtering for Fairfax County trails. You may want to merge that one instead, unless you disagree with the more stringent Fairfax filtering. |
Member
|
Yay! 🎉 Going to go ahead and merge this @alongthepike and defer to @NellePierson for input on #132. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes jurisdictional boundary geojson + modifications to generate-buffers.js to clip buffer files to those jurisdictional boundaries + newly updated buffers that have been clipped. This should satisfy #117
Note that I had to include a new set of boundary geojson files in addition to the ones that were already in the project, primarily because Fairfax needs to be clipped to Fairfax County + Fairfax City + Falls Church, not individually to those smaller jurisdictions.