This repository was archived by the owner on Nov 4, 2023. It is now read-only.
Add option to append error text to the in-valid element's parent control-group.#5
Open
mikewaters wants to merge 1 commit intoddarren:masterfrom
Open
Add option to append error text to the in-valid element's parent control-group.#5mikewaters wants to merge 1 commit intoddarren:masterfrom
mikewaters wants to merge 1 commit intoddarren:masterfrom
Conversation
…ontrol-group, instead of appending it to the invalid element itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the code appends the validation error message (a span.help-inline element) to the element that has failed validation.
This patch creates the option ('append_to_control_group') to append that error message element to it's parent control-group instead.
Reason: I have a form where inline elements are arranged in a columnar layout, like:
The validation error message for 'first-name' would break the layout, inserting the span.help-inline between first-name and last-name.
Assuming that first-name and last-name compose a control group, the error message would appear on the next line, keeping the layout intact.
Thanks,
Mike Waters