Skip to content

Potential fix for code scanning alert no. 6: Type confusion through parameter tampering #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddukbg merged 1 commit into from
Sep 9, 2025
Merged

Potential fix for code scanning alert no. 6: Type confusion through parameter tampering #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions server/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,16 +102,16 @@
app.post('/messages', async (req: Request, res: Response) => {
try {
// Extract session ID from query string and clean it
let sessionId = req.query.sessionId as string;
let sessionId = req.query.sessionId;

if (!sessionId) {
console.error('No session ID provided');
if (!sessionId || typeof sessionId !== 'string') {
console.error('Invalid or no session ID provided');
return res.status(400).json({
jsonrpc: '2.0',
id: null,
error: {
code: -32602,
message: 'Session ID required'
message: 'Valid session ID required'
}
});
}
Expand All @@ -125,7 +125,7 @@
}

if (process.env.DEBUG === 'true' || process.argv.includes('--debug')) {
console.log(`Message received for clean session ${sessionId}:`, JSON.stringify(req.body));

Check failure

Code scanning / CodeQL

Use of externally-controlled format string High

Format string depends on a
user-provided value
Loading
.
}

// Validate request body
Expand Down