feat: added a new field in settings screen, regarding maxConnection c… by ealvesss · Pull Request #72 · debba/tabularis

ealvesss · 2026-03-06T22:09:42Z

PR Description

feat: make connection pool size configurable via Settings

Problem

The maximum number of database connections per pool was hardcoded in pool_manager.rs (10 for MySQL/PostgreSQL, 5 for SQLite), with no way for users to adjust it.

Changes

Backend (src-tauri/src/)

config.rs: Added max_connections: Option to AppConfig, its merge logic in save_config, and a get_pool_max_connections() helper that reads the config file without requiring AppHandle.
pool_manager.rs: Replaced all hardcoded .max_connections() values in MySQL, PostgreSQL, and SQLite pool creation with crate::config::get_pool_max_connections().

Frontend (src/)

contexts/SettingsContext.ts: Added maxConnections to the Settings interface and DEFAULT_SETTINGS.
pages/Settings.tsx: Added a number input for Connection Pool Size in the Data Editor section of the General settings tab.
i18n/locales/{en,it,es}.json: Added translation keys maxConnections, maxConnectionsDesc, and connections.

Behavior

The setting takes effect when a new connection pool is created. Users must disconnect and reconnect for changes to apply to existing connections.
Falls back to the default value if no config is present.

…onfig

src-tauri/src/config.rs

kilo-code-bot · 2026-03-06T22:11:43Z

src-tauri/src/config.rs

+/// Get the configured maximum pool connections, or DEFAULT_MAX_CONNECTIONS if not set.
+/// Does not require AppHandle — reads config.json directly via the paths module.
+pub fn get_pool_max_connections() -> u32 {
+    let config_path = get_app_config_dir().join("config.json");


WARNING: get_pool_max_connections() may resolve a different config path than the rest of the app

get_app_config_dir() uses directories::ProjectDirs::from("", "", "tabularis"), while get_config_dir() uses app.path().app_config_dir() (Tauri's path resolver). On macOS, Tauri uses the bundle identifier to construct the config path (e.g., ~/Library/Application Support/com.tabularis.app/), while the directories crate uses the app name directly (e.g., ~/Library/Application Support/tabularis/). These can diverge, meaning get_pool_max_connections() may silently read from a different (possibly non-existent) config file and always return DEFAULT_MAX_CONNECTIONS.

Consider passing AppHandle to this function (like get_max_blob_size does) to ensure consistent path resolution, or at minimum add a test/log to verify the paths match.

src-tauri/src/pool_manager.rs

src/pages/Settings.tsx

kilo-code-bot · 2026-03-06T22:11:58Z

Code Review Summary

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	2
WARNING	0
SUGGESTION	0

Issue Details (click to expand)

CRITICAL

File	Line	Issue
`src-tauri/src/config.rs`	145	Duplicate `if config.plugins.is_some()` block - identical code exists on lines 141-143
`src/components/ui/NewConnectionModal.tsx`	341	Logic bug: setFormData unconditionally overwrites preserved form data, making driver-specific preservation ineffective

Files Reviewed (11 files)

package-lock.json - Generated file, skipped
src-tauri/Cargo.lock - Generated file, skipped
src-tauri/src/commands.rs - Pool invalidation on connection update
src-tauri/src/config.rs - Added DEFAULT_MAX_CONNECTIONS constant; has duplicate code issue
src-tauri/src/models.rs - Added max_connections field to ConnectionParams
src-tauri/src/pool_manager.rs - Configurable max_connections for MySQL/PostgreSQL pools
src/components/ui/NewConnectionModal.tsx - Added max_connections UI and driver-specific form preservation; has logic bug
src/i18n/config.ts - Formatting changes only
src/i18n/locales/en.json - Added translations for max connections
src/i18n/locales/es.json - Added translations for max connections
src/i18n/locales/it.json - Added translations for max connections
src/i18n/locales/pt-br.json - Empty file added
src/pages/Connections.tsx - Added key prop to NewConnectionModal
src/pages/Settings.tsx - Whitespace change only
src/utils/connections.ts - Added max_connections field to interface

Fix these issues in Kilo Cloud

debba · 2026-03-07T08:38:09Z

@ealvesss Thanks for the contribution! The feature is well-structured overall, but there are a few issues to address before merging.

I have 2 points I would change:

DEFAULT_MAX_CONNECTIONS = 1is a regression** — the previous hardcoded values were10for MySQL/PostgreSQL and5for SQLite. Defaulting to1` will serialize all queries and cause significant performance degradation for users who haven't explicitly configured the setting.
SQLite needs a separate cap — SQLite only supports one concurrent writer, so high pool values will cause SQLITE_BUSY / database is locked errors. It should be capped independently (e.g. params.max_connections.map(|v| v.min(5)).unwrap_or(5)), not share the same configurable value as MySQL/PostgreSQL.

Design suggestion

Rather than a global setting in the Settings page, consider moving max_connections to the individual connection configuration (ConnectionParams). This would allow users to set:

max_connections: 1 for a PostgreSQL connection behind pgBouncer
max_connections: 10 for a direct MySQL connection
SQLite capped at 5 regardless

This approach is more flexible, more explicit, and makes the global AppConfig change unnecessary — which would simplify the diff considerably.

What do you think?

ealvesss · 2026-03-11T23:53:19Z

@debba the "code-review" bots run again, after change the MR?

kilo-code-bot · 2026-03-11T23:54:09Z

src-tauri/src/config.rs

            existing_config.plugins = config.plugins;
        }

+        if config.plugins.is_some() {


CRITICAL: Duplicate code - this if config.plugins.is_some() block is identical to the one on lines 141-143. This appears to be an accidental duplication during the merge. Remove lines 145-147.

kilo-code-bot · 2026-03-11T23:54:09Z

src/components/ui/NewConnectionModal.tsx

+    }
    setDriver(newDriver);
+
    setFormData({


CRITICAL: Logic bug - this setFormData call unconditionally overwrites all the form data that was carefully preserved/restored in lines 327-337. This makes the driver-specific form data preservation feature completely ineffective.

The code should either:

Remove this hardcoded reset entirely, OR

Move it before the preservation logic (lines 325-338), OR

Merge the two setFormData calls so that preserved values are not lost

debba · 2026-03-12T12:57:31Z

@ealvesss Yes.
Btw I cannot run the project because I have the following issues:

error[E0382]: borrow of moved value: config.plugins
--> src/config.rs:145:12
|
142 | existing_config.plugins = config.plugins;
| -------------- value moved here
...
145 | if config.plugins.is_some() {
| ^^^^^^^^^^^^^^ value borrowed here after move
|
= note: move occurs because config.plugins has type std::option::Option<HashMap<std::string::String, config::PluginConfig>>, which does not implement the Copy trait

For more information about this error, try rustc --explain E0382.
error: could not compile tabularis (lib) due to 1 previous error

ealvesss · 2026-03-16T18:54:08Z

@ealvesss Yes. Btw I cannot run the project because I have the following issues:

error[E0382]: borrow of moved value: config.plugins --> src/config.rs:145:12 | 142 | existing_config.plugins = config.plugins; | -------------- value moved here ... 145 | if config.plugins.is_some() { | ^^^^^^^^^^^^^^ value borrowed here after move | = note: move occurs because config.plugins has type std::option::Option<HashMap<std::string::String, config::PluginConfig>>, which does not implement the Copy trait

For more information about this error, try rustc --explain E0382. error: could not compile tabularis (lib) due to 1 previous error

here i can run properly.

how can I reproduce this error?

debba

The config.plugins block in save_config is duplicated, causing a borrow-after-move compilation error. Remove the duplicate block (lines 145-148).

debba · 2026-03-16T19:09:34Z

src-tauri/src/config.rs

+        if config.plugins.is_some() {
+            existing_config.plugins = config.plugins;
+        }
+


This block is a duplicate of the one just above (lines 141-143). It causes a borrow-after-move compilation error because config.plugins is already moved on the first assignment.

Suggested change

if config.plugins.is_some() {

existing_config.plugins = config.plugins;

}

debba · 2026-03-16T19:10:48Z

@ealvesss sent the bug, if you can fix it and resolve conflicts, I will approve the pull request

ealvesss · 2026-03-19T01:23:05Z

@ealvesss sent the bug, if you can fix it and resolve conflicts, I will approve the pull request

I will do it soon. Probably tomorrow!

ealvesss added 2 commits March 6, 2026 19:01

feat: added a new field in settings screen, regarding maxConnection c…

02b26b6

…onfig

fix: changed default_max_connection to 1

1bf5759

kilo-code-bot bot reviewed Mar 6, 2026

View reviewed changes

debba mentioned this pull request Mar 7, 2026

[Bug]: Timeout to load schemas after connect to database (POSTGRES) #71

Open

debba force-pushed the main branch from d8fe74d to a25d46c Compare March 8, 2026 08:49

ealvesss added 2 commits March 11, 2026 20:43

fix: merge from main

d57573a

Merge branch 'main' into feat/max-conn-config

6b566d6

kilo-code-bot bot reviewed Mar 11, 2026

View reviewed changes

debba requested changes Mar 16, 2026

View reviewed changes

	if config.plugins.is_some() {
	existing_config.plugins = config.plugins;
	}

Uh oh!

Conversation

ealvesss commented Mar 6, 2026

Uh oh!

Uh oh!

kilo-code-bot bot Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kilo-code-bot bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Overview

CRITICAL

Uh oh!

debba commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ealvesss commented Mar 11, 2026

Uh oh!

kilo-code-bot bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

debba commented Mar 12, 2026

Uh oh!

ealvesss commented Mar 16, 2026

Uh oh!

debba left a comment

Choose a reason for hiding this comment

Uh oh!

debba Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

debba commented Mar 16, 2026

Uh oh!

ealvesss commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kilo-code-bot bot commented Mar 6, 2026 •

edited

Loading

debba commented Mar 7, 2026 •

edited

Loading