Allow custom events URL via GITHUB_EVENTS_URL. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<small>` doesn't work so I've used repeated `<sub><sup>` elements so that the text font is really tiny. [1] Tested in different ways so that the lack of closing sub/sup tags doesn't mess up with the next lines of text. [1] http://meta.stackexchange.com/a/107111
Hide easter egg in plain sight 😈
optimize png images using zopflipng
use minified odometer.js on CDNJS to benefit from http/2
Add a feature to filter out events of specified repos/orgs
Allow fetching custom events, by setting the `GITHUB_EVENTS_URL` environment variable. The value of `GITHUB_EVENTS_URL` can be anyone of the URLs listed [here](https://developer.github.com/v3/activity/events/). Also added port to socketio initialization to fix local development.
mcornella
reviewed
Oct 9, 2016
app/public/js/main.js
Outdated
|
|
||
|
|
||
| var socket = io(document.location.hostname); | ||
| var socketHost = document.location.hostname + ":" + document.location.port; |
Contributor
There was a problem hiding this comment.
I've fixed this on my end, using just document.location.host which includes the port: 75451ca.
Author
There was a problem hiding this comment.
Kewl, will revert this change
Owner
|
Hey @erikzaadi thanks for the PR! Could you please fix the merge conflict, it's a small one. |
Contributor
|
@debugger22 you can check out the PR yourself and do the rebase. |
|
Would this close #26? We think it might. |
debugger22
force-pushed
the
master
branch
2 times, most recently
from
872e658 to
e5d1bb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow fetching custom events, by setting the
GITHUB_EVENTS_URLenvironment variable.The value of
GITHUB_EVENTS_URLcan be anyone of the URLs listed here.Also added Gravatar support