Skip to content

fix(vmsop): add create VM from snapshot operation #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(vmsop): add create VM from snapshot operation #1632

wants to merge 7 commits into from
+3,639 −79

Conversation

@danilrwx
Copy link
Contributor

@danilrwx danilrwx commented Oct 28, 2025 •
edited
Loading

Description

Creating a VM clone from a snapshot is implemented by the VirtualMachineSnapshotOperation resource:

apiVersion: virtualization.deckhouse.io/v1alpha2
kind: VirtualMachineSnapshotOperation
metadata:
  name: vmsop
spec:
  type: CreateVirtualMachine
  virtualMachineSnapshotName: vm-snapshot
  createVirtualMachine:
    mode: Strict
    customization:
      nameSuffix: "suff"

What is the expected result?

New resource, which create VM from snapshot. Working GC for thats operations, logic same as VMOP Clone.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: core
type: feature
summary: Add VirtualMachineSnapshotOperations.

sourcery-ai[bot]
sourcery-ai bot reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @danilrwx, your pull request is larger than the review limit of 150000 diff characters

@danilrwx danilrwx added this to the v1.2.0 milestone Nov 7, 2025
@danilrwx danilrwx force-pushed the feat/vmsop/clone branch 2 times, most recently from 1ef5ae5 to e54ce5d Compare November 10, 2025 20:09
@danilrwx danilrwx marked this pull request as ready for review November 11, 2025 03:40
@danilrwx danilrwx added the e2e/run Run e2e test on cluster of PR author label Nov 11, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 11, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Nov 11, 2025
@z9r5 z9r5 requested a review from MargaretKozlova November 11, 2025 07:55
@danilrwx danilrwx added the e2e/run Run e2e test on cluster of PR author label Nov 11, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 11, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Nov 11, 2025
@danilrwx danilrwx added the e2e/run Run e2e test on cluster of PR author label Nov 11, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 11, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@MargaretKozlova MargaretKozlova requested review from prismagod and removed request for MargaretKozlova November 11, 2025 09:18
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Nov 11, 2025
@danilrwx danilrwx added the e2e/run Run e2e test on cluster of PR author label Nov 11, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 11, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Nov 11, 2025
@danilrwx danilrwx force-pushed the feat/vmsop/clone branch 3 times, most recently from e733b79 to 7836b9e Compare November 11, 2025 14:24
@danilrwx danilrwx force-pushed the feat/vmsop/clone branch 3 times, most recently from 2c7e8d2 to 7e955fb Compare November 11, 2025 19:34
@danilrwx danilrwx added the e2e/run Run e2e test on cluster of PR author label Nov 11, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 11, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Nov 11, 2025
@danilrwx danilrwx added the e2e/run Run e2e test on cluster of PR author label Nov 12, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 12, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Nov 12, 2025
@danilrwx danilrwx added the e2e/run Run e2e test on cluster of PR author label Nov 12, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 12, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Nov 12, 2025
prismagod
prismagod previously approved these changes Nov 12, 2025
View reviewed changes
z9r5
z9r5 previously approved these changes Nov 13, 2025
View reviewed changes
@danilrwx danilrwx dismissed stale reviews from z9r5 and prismagod via d2c4374 November 13, 2025 09:07
danilrwx and others added 5 commits November 13, 2025 11:10
@danilrwx
feat(vmsop): clone
02760e3 
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

feat(vmsop): fix diagnostic errors

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

fix

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

fix

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

remove unused

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

fix crds

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

update

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

update

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

fix types

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

fix

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

del useless

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

correct names

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

test again

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

update text

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

return metrics

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

fix panic

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

fix lint

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

fix test

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

add doc-ru

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

fix doc

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

update

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
@danilrwx
fix GC
e6c0843 
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
@prismagod @danilrwx
Review
7d23bdf 
Signed-off-by: Vladislav Panfilov <vladislav.panfilov@flant.com>
@danilrwx
add test
97c0b06 
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

fix e2e

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
@danilrwx
update gen
9d21795 
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
@danilrwx
fix alias
06e9a32 
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
@danilrwx
fix format
8e1eb50 
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
@danilrwx danilrwx added the e2e/run Run e2e test on cluster of PR author label Nov 13, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 13, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@z9r5 z9r5 z9r5 approved these changes

@prismagod prismagod prismagod left review comments

@Isteb4k Isteb4k Awaiting requested review from Isteb4k Isteb4k is a code owner

@yaroslavborbat yaroslavborbat Awaiting requested review from yaroslavborbat yaroslavborbat is a code owner

@fl64 fl64 Awaiting requested review from fl64 fl64 is a code owner

@goganat goganat Awaiting requested review from goganat goganat is a code owner

@universal-itengineer universal-itengineer Awaiting requested review from universal-itengineer

@nevermarine nevermarine Awaiting requested review from nevermarine

Assignees

@danilrwx danilrwx

Labels

None yet

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@danilrwx @deckhouse-BOaTswain @z9r5 @prismagod