Parameter to configure database connection encryption#586
Parameter to configure database connection encryption#586isuldor wants to merge 1 commit intodecred:masterfrom isuldor:sqltls
Conversation
|
I don't need to supply a certificate? |
|
I'm glad you brought that up because I'm not sure, and frankly puzzled as to why go's mysql driver would require that with a valid certificate. On the one hand, a simple test script with Either way, adding a configurable pem file with mysql.RegisterTLSConfig for folks using self-signed certs makes sense. I also omitted it since I'm not exactly sure where and how it should be implemented. |
|
This looks good to me, but I would like to enable custom certificates using the code you linked. If you don't feel comfortable doing it, I can in another pr. |
|
This PR only adds support for stakepoold, but dcrstakepool also connects to the db. We should probably add support for both. |
--dbtlsis a configurable parameter to set the go-sql-driver/mysql option for tls. [1]1: https://github.com/go-sql-driver/mysql#tls