Open
Conversation
jrick
requested changes
Jul 8, 2019
Member
jrick
left a comment
jrick
left a comment
There was a problem hiding this comment.
Not sure what this upgrade is for so this is difficult to review without seeing the associated upgrade code as well.
Depending on what this upgrade does, may want to also save the same script to the Store as well (which is not encrypted). This is what the wallet currently does when importing scripts.
dnldd
force-pushed
the
script_storage_testdata
branch
from
a82156a to
18d887d
Compare
dnldd
force-pushed
the
script_storage_testdata
branch
from
18d887d to
829aec9
Compare
dnldd
force-pushed
the
script_storage_testdata
branch
from
829aec9 to
7037b3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation of v13 db upgrade.