Open
Conversation
ccf5aba to
d521335
Compare
d521335 to
d3aeb2d
Compare
jrick
reviewed
Aug 13, 2019
Member
|
Hmm, so this isn't quite what I had in mind when I was talking about changing fetchAccountInfo to not return a type specific to BIP0044 accounts. I was instead thinking that the call should return some sort of interface type, and that following code to either operates on the generic account interface, or type asserts it for more specific features (e.g. type asserting to access an xpub). |
d3aeb2d to
c523076
Compare
Member
Author
|
This updates account row related functions to use the account row interface for more flexibility. Serialization and deserialization have been reduced to a one step process instead of converting to the intermediate dbAccountRow type first.
c523076 to
58b9307
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates account row related functions to use the account row interface for more flexibility and in preparation of adding new account types. Serialization and deserialization have been reduced to a one step process instead of converting to the intermediate
dbAccountRowtype first.