multi: Expand the API to support retrieving paid amounts. #1698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Author
|
@ukane-philemon I've fixed it. Please check it again for me. Thank you very much! |
Author
|
@ukane-philemon I don't know when this PR will be merged and what the deployment process is. I think we need to deploy quickly to be able to provide information to the community |
|
@thanhnp95, please ask on the politeia channel on element. |
JoeGruffins
approved these changes
Apr 1, 2025
Member
JoeGruffins
left a comment
JoeGruffins
left a comment
There was a problem hiding this comment.
Looks good however I am unable to test without setting up a server.
Member
|
One more nit, the commit title should be something like: https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html |
thanhnp95
changed the title
Co-authored-by: JoeGruffins <34998433+JoeGruffins@users.noreply.github.com>
Co-authored-by: JoeGruffins <34998433+JoeGruffins@users.noreply.github.com>
Co-authored-by: JoeGruffins <34998433+JoeGruffins@users.noreply.github.com>
Co-authored-by: JoeGruffins <34998433+JoeGruffins@users.noreply.github.com>
Co-authored-by: JoeGruffins <34998433+JoeGruffins@users.noreply.github.com>
thanhnp95
force-pushed
the
proposal-billed-state-api
branch
from
7f32102 to
4f437a9
Compare
Author
|
@JoeGruffins Thank you very much for reviewing my PR. I have incorporated your suggested changes and hope you can provide further support so that the PR can be merged and deployed quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resoved issue: #1697
Created API to support getting actual payment data for proposal
ApiRoute: /v1/proposals/billedstate
Type: Public API
Input: proposal token
Output: Payment times and amounts paid for proposal
{ "totalbilled": int64, "paidinvoices": [{ "timestamp": int64, "total": int64, }] }