Add manual ticket search feature.#322
Open
ukane-philemon wants to merge 1 commit intodecred:masterfrom
Open
Conversation
ukane-philemon
force-pushed
the
ManualTicketSearch
branch
from
4822daf to
4da873b
Compare
jholdstock
requested changes
Mar 15, 2022
Member
jholdstock
left a comment
jholdstock
left a comment
There was a problem hiding this comment.
Hi @ukane-philemon,
I would love to get some of these changes broken out into a separate PR if you don't mind. I am specifically thinking of the validateTicketHash() and getCommitmentAddress() functions you have added to helpers.go.
These are valuable changes in their own right, which can be merged while we are still working out implementation details for #227.
Merging them seperately will also help by reducing the changeset of this PR, making it easier to review and less likely to introduce bugs.
Contributor
Author
|
@jholdstock thanks for the review, changes applied. |
ukane-philemon
force-pushed
the
ManualTicketSearch
branch
from
4da873b to
cf433bb
Compare
ukane-philemon
force-pushed
the
ManualTicketSearch
branch
from
cf433bb to
3f45dee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds manual ticket search feature to the vspd frontend. Tickets owners can search tickets with a base64 encoded string containing the ticket hash and signature. if ownership validation is successful, ticket owners can view full information about their ticket. This aids confirming if ticket registration is successful without depending on decrediton or dcrwallet verifying via an api. closes #227
Ticket page:
Homepage before:
Modified Homepage: