Parallel blocking for pgsql_big_dedupe_example.py#114
Open
fjsj wants to merge 6 commits intodedupeio:mainfrom
Open
Parallel blocking for pgsql_big_dedupe_example.py#114fjsj wants to merge 6 commits intodedupeio:mainfrom
fjsj wants to merge 6 commits intodedupeio:mainfrom
Conversation
fjsj
commented
Sep 19, 2020
| predicates_without_index.append(full_predicate) | ||
|
|
||
| # Use only predicates WITHOUT indexes for parallel blocking | ||
| deduper.fingerprinter.predicates = predicates_without_index |
Author
There was a problem hiding this comment.
I've found a problem here... due to these lines:
The enumerate is causing the predicate to have a different pred_id compared to the serial version. This only happens if there's an index predicate. What would be the best way to solve this? Changing Dedupe internally or doing some workaround here?
Contributor
There was a problem hiding this comment.
hmm.. that is interesting. enumerate is just identifying the predicate. we could accomplish the same thing by having the predicates be hashable and using the hash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to dedupeio/dedupe#831
Tested with Python 3.7.7 on macOS 10.15.6 (19G2021) and PostgreSQL 12.3.
Running times for blocking only are:
Both versions are available at commit c1c8384 along with a script for testing (
pgsql_big_dedupe_example/test_parallel_vs_serial.sh).The settings file and the training file are here: settings-and-training.zip. The no-index one was trained with 0.99 recall. The index one with 0.90.