Add support for partial SQL and partial post filtering in WhereBuilder#685
Open
MrSnyder wants to merge 1 commit intodeegree:mainfrom
Open
Add support for partial SQL and partial post filtering in WhereBuilder#685MrSnyder wants to merge 1 commit intodeegree:mainfrom
MrSnyder wants to merge 1 commit intodeegree:mainfrom
Conversation
… of an AND-based filter can be mapped to the database.
Member
|
The TMC discussed this pull requests and we like this approach. We are however somewhat hesitant to merge this right now because we very much like this new behavior to be opt-in instead to the new default behavior. Adding a configuration setting for this would be a great improvement to this pull request. |
|
Thank you for your contribution. Unfortunately, this PR has been inactive for 90 days (see PR stuck workflow). Of course this is not the final word. The PR can become unstuck, for example, by reengaging in the discussion, answering open questions, rebasing, or adding new commits to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this patch, the WhereBuilder would either map a complete filter to a WHERE clause or (in case some parts of the filter are unmappable) use an empty WHERE clause and offer the complete filter for in-memory filtering.
A shortcoming of this approach is that a single unmappable part of a filter means that all objects will be be fetched from the database and will be filtered in memory. Depending on the structure of the filter, this can be improved, so the WHERE-clause can still be used to narrow the result set.
After this patch, the WhereBuilder supports partial SQL and partial in-memory filtering for a common use case: If the filter is based on a root AND operator, the filter will be split into a WHERE clause and a post filter part. The WHERE clause contains all mappable parts and the post filter the remaining parts.
Tests included.