Rewrite Black Sea GeoJSON to conform to current schema#7
Rewrite Black Sea GeoJSON to conform to current schema#7
Conversation
Content is not yet complete: placeholders are used for sources.data_url and sources.license_url in the variable properties.
pont-us
requested review from
AliceBalfanz and
forman
and removed request for
AliceBalfanz and
forman
forman
left a comment
forman
left a comment
There was a problem hiding this comment.
I believe, we should meet to consolidate the GeoJSON structure.
One way to move forward, is to only specify a subset of properties specified by CF Convention and ones defined by https://wiki.esipfed.org/Attribute_Convention_for_Data_Discovery_1-3 so we can use them as metadata directly.
| "valid_min": -3.4028234663852886e+38, | ||
| "valid_max": 3.4028234663852886e+38, |
There was a problem hiding this comment.
Are these the true valid_min and valid_max? Note that they replace fill_value.
I'm not sure why we include them.
If we want useful limits for the tiles in xcube Viewer, we should use color_value_min and color_value_max.
There was a problem hiding this comment.
These are true in the sense of being the minimum and maximum representable values for the float32 data type used for this variable. But I couldn't find any documentation of the semantics of these fields, so I don't know if this was the intended sense of "valid".
| "valid_min": -3.4028234663852886e+38, | ||
| "valid_max": 3.4028234663852886e+38, |
The content of the "source" item in the per-variable metadata object duplicates the content of the "remarks" item in the first (and only) "sources" object. Removing "source" to avoid redundancy.
|
I've opened another pull request for the schema and template at deepesdl/dataset-spec#5, so that I can update them in parallel with the changes happening here. |
2 participants
License URLs for the variables are currently set to UNKNOWN, but all other fields have been populated from the previous GeoJSON or from other data in the
black-seadirectory in this repository. The GeoJSON in this PR has been validated against the current version of the DeepESDL dataset schema.