perf: MegaMerge, use explicit comparison operator #5819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
added
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
force-pushed
the
perf-mega-merge-kernels
branch
from
a17b502 to
c947b31
Compare
rcaudy
reviewed
Jul 21, 2024
| final long mid = (lo + hi) >>> 1; | ||
| final char testValue = valuesToSort.getUnsafe(mid); | ||
| final boolean moveLo = doComparison(testValue, searchValue) <= compareLimit; | ||
| final boolean moveLo = strict ? lt(testValue, searchValue) : leq(testValue, searchValue); |
Member
There was a problem hiding this comment.
I don't know if this matters a lot, but the previous version was written to branch only once, outside the while loop, instead of on every iteration. I imagine a JIT compiler can optimize this, though, and it the suppression on the method suggests that we only take one of these branches ever.
rcaudy
reviewed
Jul 21, 2024
| @SuppressWarnings("SameParameterValue") final boolean lower) { | ||
| final int compareLimit = lower ? -1 : 0; // lt or leq | ||
|
|
||
| @SuppressWarnings("SameParameterValue") final boolean strict) { |
Member
There was a problem hiding this comment.
I don't think renaming this is aiding clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic is identical, but this provides the JVM a more specific target to optimize.