-
Notifications
You must be signed in to change notification settings - Fork 16
feat: expands theme pack with 10 new themes #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR expands the theme-pack plugin with 10 new themes generated from VS Code theme schemas using AI assistance. It adds Playwright test coverage for theme rendering, includes a Claude.md guide for AI-assisted theme generation, and updates documentation.
Changes:
- Adds 10 new themes (Dracula, IntelliJ Dark/Light, Kimbie Dark, Night Owl, Red, Solarized Dark/Light, SynthWave '84, Tomorrow Night Blue)
- Implements Playwright test suite with visual regression testing for all themes
- Adds Claude.md documentation for AI-assisted theme generation
- Updates README with VS Code theme inspection instructions
Reviewed changes
Copilot reviewed 17 out of 57 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/theme.spec.ts | New Playwright test suite for theme visual regression testing |
| tests/app.d/theme_demo.py | Test dashboard with table, chart, markdown, and UI controls |
| tests/app.d/tests.app | Adds theme_demo.py to test application manifest |
| plugins/theme-pack/src/js/src/tomorrow-night-blue-theme.css | Example of new AI-generated theme with complete color palette |
| plugins/theme-pack/src/js/src/index.ts | Updated to register all 11 themes (1 existing + 10 new) |
| plugins/theme-pack/src/js/package.json | Adds colorjs.io dependency for theme generation |
| plugins/theme-pack/src/js/README.md | Documents Claude.md and VS Code theme inspection |
| tests/theme.spec.ts-snapshots/theme-Tomorrow-Night-Blue-webkit-linux.png | Visual regression baseline screenshot |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mofojed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the e2e tests failing? Looks like the random seeding is off, but I thought we had that fixed a while ago. Grr
Oh I think I know why, the file scripts are global, I had re-used a variable name _stocks, and did a tail 100 on stocks before charting because I wanted it to be able to initialize and switch themes faster with less data. |
Adds Claude.md file that was used to generate a bunch of new themes from VS Code theme schemas, along with adding a selection of 10 new themes to the theme-pack. A few minor tweaks were hand edited, but otherwise the theme files are entirely AI generated.
It is easy to pass a vs code theme schema straight to claude and have it spit out a decent approximation.
Updated the readme in theme pack to note the existence of claude.md,
Added playwright coverage on the themes selection and output.
Some things I noticed: