plan: add feature plan for DH-21375 databars integration with TableFormat #1282
+574
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive guide for AI agents working in the deephaven-plugins repository covering: - Environment setup (Python and JavaScript) - Building plugins (Python wheels and JS bundles) - Running unit tests (tox) and E2E tests (Playwright) - Running development server (deephaven-core and Docker) - Documentation preview and snapshot generation - Code quality and pre-commit hooks - Common development workflows - Release management Prioritizes local development workflows over Docker-based approaches.
Add feature planning infrastructure: - Create plugins/ui/plans/ directory for feature plan documents - Add README with naming convention (ticket number + keyword) - Define plan document structure (overview, goals, design, implementation, testing, docs, open questions) - Update AGENTS.md with general instructions for creating feature plans in any plugin
…rmat Create comprehensive plan document for integrating databars into ui.TableFormat: - Align databars with other formatting features for API consistency - Enable conditional databars with if_ parameter support - Maintain backward compatibility with deprecated databars parameter - Define 5-phase implementation: foundation, JS integration, testing, docs, cleanup - Document testing strategy, migration guide, and success criteria - Address open design questions with recommendations
|
Pull Request titles must follow the Conventional Commits specification. Details: |
Contributor
|
Whatever you come up with, keep in mind the heatmap function will likely share like 70% of the same props (min/max/colors[]/value_column etc.) Ideally, a single change could switch between the two. Just take that into consideration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gzh2003 @mattrunyon take a look at the proposal in the DH-21375 planning document as part of this PR and see if you have any comments about it. Can try playing with databars as they are currently to help inform your opinion: https://deephaven.io/core/ui/docs/components/table/#formatting-databars
Create comprehensive plan document for integrating databars into ui.TableFormat: