feat: Add shared objects to embed-widget #2189
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
reviewed
Aug 15, 2024
mofojed
reviewed
Aug 15, 2024
mofojed
reviewed
Aug 15, 2024
mofojed
reviewed
Aug 15, 2024
mofojed
requested changes
Aug 15, 2024
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Need to clean up a few things.
mofojed
requested changes
Aug 15, 2024
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Need to clean up a few things.
mofojed
requested changes
Aug 28, 2024
| const isLoaded = | ||
| (definition != null || sharedObject != null) && error == null; | ||
| const isLoading = definition == null && sharedObject == null && error == null; | ||
| (definition != null || sharedReady != false) && error == null; |
Member
There was a problem hiding this comment.
Suggested change
| (definition != null || sharedReady != false) && error == null; | |
| (definition != null || sharedReady) && error == null; |
| (definition != null || sharedObject != null) && error == null; | ||
| const isLoading = definition == null && sharedObject == null && error == null; | ||
| (definition != null || sharedReady != false) && error == null; | ||
| const isLoading = definition == null && sharedReady == false && error == null; |
Member
There was a problem hiding this comment.
Suggested change
| const isLoading = definition == null && sharedReady == false && error == null; | |
| const isLoading = definition == null && !sharedReady && error == null; |
Comment on lines
+169
to
+180
| type ConnectionWithGetSharedObject = dh.IdeConnection & { | ||
| getSharedObject(name: string, type: string): Promise<unknown>; | ||
| }; | ||
|
|
||
| function isConnectionWithGetSharedObject( | ||
| connection: dh.IdeConnection | ||
| ): connection is ConnectionWithGetSharedObject { | ||
| return ( | ||
| 'getSharedObject' in connection && | ||
| typeof connection.getSharedObject === 'function' | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
Move the type definition and typePredicate outside of/above this functional component.
| 'Connection does not have getSharedObject method. Cannot fetch shared object.' | ||
| ); | ||
| } | ||
| if (definition != null) { |
Member
There was a problem hiding this comment.
I'd personally put the definition != null case first.
Member
|
There's been no action or direction on this PR for months. Closing, will re-open if we want to pick up shared tickets again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires deephaven/deephaven-core#5854
Adds ability to fetch shared objects with
embed-widget.nametakes the shared ticket, thensharedspecifies the type of shared object that needs to be fetched, which is required forgetSharedObject.