Revert "[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] bpf: Fix kabi in bpf_map_owner by using KABI_EXTEND"#1498
Closed
opsiff wants to merge 1 commit intolinux-6.6.yfrom
Closed
Conversation
This reverts commit 3ab9823.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR reverts a previous Deepin-specific KABI extension to bpf_map_owner by restoring expected_attach_type to a normal enum field, effectively undoing the KABI_EXTEND usage introduced earlier. Class diagram for reverted KABI extension in bpf_map_ownerclassDiagram
class bpf_map_owner {
bool xdp_has_frags
u64 storage_cookie[MAX_BPF_CGROUP_STORAGE_TYPE]
const btf_type* attach_func_proto
enum bpf_attach_type expected_attach_type
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since this reverts the KABI_EXTEND usage for
expected_attach_type, please double-check other fields instruct bpf_map_owner(and related structs) for similar wrappers to ensure the ABI layout is consistently aligned with the original design. - Consider adding a brief comment near
expected_attach_typeexplaining why it must not useDEEPIN_KABI_EXTEND(i.e., to preserve the original ABI layout), so future changes don’t inadvertently reintroduce the same issue.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since this reverts the KABI_EXTEND usage for `expected_attach_type`, please double-check other fields in `struct bpf_map_owner` (and related structs) for similar wrappers to ensure the ABI layout is consistently aligned with the original design.
- Consider adding a brief comment near `expected_attach_type` explaining why it must not use `DEEPIN_KABI_EXTEND` (i.e., to preserve the original ABI layout), so future changes don’t inadvertently reintroduce the same issue.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1368
Summary by Sourcery
Bug Fixes: