Skip to content

Revert "[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] net: netpoll: Fix kabi in netpoll by using KABI_EXTEND"#1499

Closed
opsiff wants to merge 1 commit intolinux-6.6.yfrom
revert-1367-linux-6.6.y-2025-12-10-kabi-1
Closed

Revert "[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] net: netpoll: Fix kabi in netpoll by using KABI_EXTEND"#1499
opsiff wants to merge 1 commit intolinux-6.6.yfrom
revert-1367-linux-6.6.y-2025-12-10-kabi-1

Conversation

@opsiff
Copy link
Member

@opsiff opsiff commented Feb 10, 2026

Reverts #1367

Summary by Sourcery

Enhancements:

  • Simplify netpoll KABI handling by making skb_pool a regular struct member instead of using DEEPIN_KABI_EXTEND.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 10, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR reverts a previous change to netpoll KABI handling by removing the DEEPIN_KABI_EXTEND usage for skb_pool and restoring skb_pool as a regular struct member, while leaving the KABI reserve slots intact.

Class diagram for updated netpoll struct layout

classDiagram
    class netpoll {
        +char* name
        +struct net_device* dev
        +struct napi_struct* napi
        +u32 local_ip
        +u32 remote_ip
        +bool ipv6
        +u16 local_port
        +u16 remote_port
        +u8 remote_mac[ETH_ALEN]
        +struct sk_buff_head skb_pool
        +DEEPIN_KABI_RESERVE_1
        +DEEPIN_KABI_RESERVE_2
    }
Loading

File-Level Changes

Change Details Files
Restore skb_pool as a normal field in struct netpoll instead of using DEEPIN_KABI_EXTEND.
  • Add struct sk_buff_head skb_pool as a direct member of struct netpoll
  • Remove DEEPIN_KABI_EXTEND macro usage for skb_pool while keeping DEEPIN_KABI_RESERVE(1) and DEEPIN_KABI_RESERVE(2) unchanged
include/linux/netpoll.h

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@opsiff
Copy link
Member Author

opsiff commented Feb 10, 2026

#1501

@opsiff opsiff closed this Feb 10, 2026
@opsiff opsiff deleted the revert-1367-linux-6.6.y-2025-12-10-kabi-1 branch February 10, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants