Skip to content

fix: cache level json data on temporary files to avoid memory issues #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
parvit wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: cache level json data on temporary files to avoid memory issues #1185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 39 additions & 5 deletions src/electron.renderer/data/Level.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
package data;

import haxe.io.Path;
import sys.FileSystem;
import sys.io.File;

class Level {
var _project : Project;
public var _world : World;

var _cachedJson : Null<{ str:String, json:ldtk.Json.LevelJson }>;
var _cachedJson : Null<{ path:String, json:ldtk.Json.LevelJson }>;

@:allow(data.Project, data.World)
public var uid(default,null) : Int;
Expand Down Expand Up @@ -372,15 +376,41 @@ class Level {


public inline function hasJsonCache() return _cachedJson!=null;
public inline function invalidateJsonCache() _cachedJson = null;
public function rebuildCache() {
public inline function invalidateJsonCache() {
if( _cachedJson!=null ) {
FileSystem.deleteFile( _cachedJson.path );
}
_cachedJson = null;
}
public function rebuildCache() {
invalidateJsonCache();
toJson();
}

function tempDirectory() {
var tempDir = Sys.environment()['TMP'];
if (tempDir == null) {
tempDir = Sys.environment()['TEMP'];
}
return tempDir;
}

function setJsonCache(json:ldtk.Json.LevelJson, skipHeader:Bool) {
var tempDir = tempDirectory();
var tempFileName = 'level-${this.uid}-${this.iid}.json';
var tempFilePath = Path.join([tempDir, tempFileName]);

try {
var jsonStr = ui.ProjectSaver.jsonStringify(_project, json, skipHeader );
File.saveContent(tempFilePath, jsonStr);
jsonStr = null;

} catch (e:Dynamic) {
trace('An error occurred: $e');
}

_cachedJson = {
str: ui.ProjectSaver.jsonStringify(_project, json, skipHeader ),
path: tempFilePath,
json: json,
}
}
Expand All @@ -394,7 +424,11 @@ class Level {
}

public function getCacheJsonString() : Null<String> {
return hasJsonCache() ? _cachedJson.str : null;
if( !hasJsonCache() ) {
return null;
}

return File.getContent(_cachedJson.path);
}

public function getBgTileInfos() : Null<{ imgData:data.DataTypes.CachedImage, tx:Float, ty:Float, tw:Float, th:Float, dispX:Int, dispY:Int, sx:Float, sy:Float }> {
Expand Down