-
Notifications
You must be signed in to change notification settings - Fork 40
[test] PostureManager: add test case for the TescanPostureManager on Tescan FIBSEM #3331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] PostureManager: add test case for the TescanPostureManager on Tescan FIBSEM #3331
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThis pull request adds rotation metadata (180 degrees) to the EBeam Scanner and Ion Scanner detectors in the Tescan Fibsem simulation configuration file. Additionally, new test classes are introduced to the move_tescan_test module to exercise Fibsem hardware configuration scenarios, mirroring existing Tescan behavior with Fibsem-specific parameters. The move_tfs3_test module is updated with a setUp method for stage posture initialization and adjusted timing parameters to reflect faster simulated stage updates. Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds test coverage for the Tescan PostureManager on a Tescan FIBSEM (Meteor) by reusing the existing TFS3 posture/transform test suite, and aligning the Tescan simulator configuration with expected scan rotation.
Changes:
- Updated the TFS3 movement tests to add a per-test setup step (and reduced sleep delays) to improve test stability when re-used by other platforms.
- Added a new Tescan FIBSEM test class that reuses the TFS3 test suite and overrides/adjusts Tescan-specific expectations.
- Updated the Tescan FIBSEM simulator config to set standard 180° scan rotation for both e-beam and ion-beam scanners.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/odemis/acq/test/move_tfs3_test.py |
Adds a setUp() posture reset path and reduces sleep times to support reliable posture/transform tests. |
src/odemis/acq/test/move_tescan_test.py |
Introduces TestMeteorFibsemTescan1Move that reuses TFS3 tests for Tescan FIBSEM and adds Tescan-specific movement assertions. |
install/linux/usr/share/odemis/sim/meteor-tescan-fibsem-full-sim.odm.yaml |
Configures e-beam/ion-beam scan rotation to 180° to match expected camera/motion behavior in tests. |
…Tescan FIBSEM Use the same test cases as for the TFS3 FIBSEM to test the TescanPostureManager with the Meteor FIBSEM on Tescan.
28a2d2a to
2133399
Compare
Use the same test cases as for the TFS3 FIBSEM to test the
TescanPostureManager with the Meteor FIBSEM on Tescan.