Skip to content

Conversation

@pieleric
Copy link
Member

Use the same test cases as for the TFS3 FIBSEM to test the
TescanPostureManager with the Meteor FIBSEM on Tescan.

Copilot AI review requested due to automatic review settings January 26, 2026 10:26
@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

Warning

Rate limit exceeded

@pieleric has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 15 minutes and 15 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

This pull request adds rotation metadata (180 degrees) to the EBeam Scanner and Ion Scanner detectors in the Tescan Fibsem simulation configuration file. Additionally, new test classes are introduced to the move_tescan_test module to exercise Fibsem hardware configuration scenarios, mirroring existing Tescan behavior with Fibsem-specific parameters. The move_tfs3_test module is updated with a setUp method for stage posture initialization and adjusted timing parameters to reflect faster simulated stage updates.

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: adding test cases for TescanPostureManager on Tescan FIBSEM hardware.
Description check ✅ Passed The description is related to the changeset, explaining the intent to test TescanPostureManager using existing TFS3 FIBSEM test cases.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds test coverage for the Tescan PostureManager on a Tescan FIBSEM (Meteor) by reusing the existing TFS3 posture/transform test suite, and aligning the Tescan simulator configuration with expected scan rotation.

Changes:

  • Updated the TFS3 movement tests to add a per-test setup step (and reduced sleep delays) to improve test stability when re-used by other platforms.
  • Added a new Tescan FIBSEM test class that reuses the TFS3 test suite and overrides/adjusts Tescan-specific expectations.
  • Updated the Tescan FIBSEM simulator config to set standard 180° scan rotation for both e-beam and ion-beam scanners.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/odemis/acq/test/move_tfs3_test.py Adds a setUp() posture reset path and reduces sleep times to support reliable posture/transform tests.
src/odemis/acq/test/move_tescan_test.py Introduces TestMeteorFibsemTescan1Move that reuses TFS3 tests for Tescan FIBSEM and adds Tescan-specific movement assertions.
install/linux/usr/share/odemis/sim/meteor-tescan-fibsem-full-sim.odm.yaml Configures e-beam/ion-beam scan rotation to 180° to match expected camera/motion behavior in tests.

…Tescan FIBSEM

Use the same test cases as for the TFS3 FIBSEM to test the
TescanPostureManager with the Meteor FIBSEM on Tescan.
@pieleric pieleric force-pushed the test-posturemanager-add-test-case-for-the-tescanposturemanager-on-tescan-fibsem branch from 28a2d2a to 2133399 Compare January 28, 2026 10:38
@pieleric pieleric merged commit 646a912 into delmic:master Jan 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants