Python >=3.9 compat, update packaging#294
Draft
sneakers-the-rat wants to merge 4 commits intodenisecailab:masterfrom
Draft
Python >=3.9 compat, update packaging#294sneakers-the-rat wants to merge 4 commits intodenisecailab:masterfrom
sneakers-the-rat wants to merge 4 commits intodenisecailab:masterfrom
Conversation
|
|
||
| __version__ = "1.2.1" | ||
| try: | ||
| __version__ = version("minian") |
Author
There was a problem hiding this comment.
wasn't sure why version was defined in 4 different places, so reduced it to only two (not sure what that committizen tool does)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@phildong got this started for ya last night, basically i just updated the packaging to modern pyproject.toml style, set a new minimum, ran ruff's pyupgrade formatter, and then started running the tests and whacking away at whatever bugs started to happen. mostly just simple API changes in dependencies. shouldn't take too much longer to get it working. bonus: this should also resolve many of the installation issues i'm seeing as well as make it possible to put this up on pypi.
opening as a draft with allow edits by maintainers, you should be able to push directly to this branch like