Skip to content

Python >=3.9 compat, update packaging#294

Draft
sneakers-the-rat wants to merge 4 commits intodenisecailab:masterfrom
sneakers-the-rat:py39
Draft

Python >=3.9 compat, update packaging#294
sneakers-the-rat wants to merge 4 commits intodenisecailab:masterfrom
sneakers-the-rat:py39

Conversation

@sneakers-the-rat
Copy link

@phildong got this started for ya last night, basically i just updated the packaging to modern pyproject.toml style, set a new minimum, ran ruff's pyupgrade formatter, and then started running the tests and whacking away at whatever bugs started to happen. mostly just simple API changes in dependencies. shouldn't take too much longer to get it working. bonus: this should also resolve many of the installation issues i'm seeing as well as make it possible to put this up on pypi.

opening as a draft with allow edits by maintainers, you should be able to push directly to this branch like

git remote add sneakers-the-rat https://github.com/sneakers-the-rat/minian
git fetch sneakers-the-rat
git switch -c py39 sneakers-the-rat/py39
# do stuff... commit... push as normal


__version__ = "1.2.1"
try:
__version__ = version("minian")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't sure why version was defined in 4 different places, so reduced it to only two (not sure what that committizen tool does)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant