Skip to content

fix(prefer-primordials): allow private identifier in in expression #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
0f-0b wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(prefer-primordials): allow private identifier in in expression #1308

0f-0b wants to merge 1 commit into from
+34 −14

Conversation

@0f-0b
Copy link
Contributor

@0f-0b 0f-0b commented Aug 13, 2024

No description provided.

@petamoriken
Copy link
Contributor

petamoriken commented Aug 15, 2024

I suggested banning the in operator to enforce proper use of Reflect.has and Object.hasOwn, but in most cases Object.hasOwn was not used in Deno internal. It might be better to simply allow the in operator for DX and performance 🙇

@petamoriken
Copy link
Contributor

petamoriken commented Aug 16, 2024

@lucacasonato What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0f-0b @petamoriken