Fix leading ticket number #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekeal
reviewed
Nov 7, 2024
Comment on lines
20
to
24
| def is_ticket_in_message(contents, ticket): | ||
| for line in contents.splitlines(): | ||
| for i, line in enumerate(contents.splitlines()): | ||
| stripped = line.strip().lower() | ||
|
|
||
| if stripped == "" or stripped.startswith("#"): | ||
| if stripped == "" or (stripped.startswith("#") and i != 0): |
Contributor
There was a problem hiding this comment.
Consider adding a docstring 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior:
When the
--formatargument starts with#{ticket}, duringgit commit --amend --no-editan additional task number was added at the beginning.Expected behavior:
When the commit message starts with
#{ticket}(only on the first line), do not add it again.Fix applied:
Skip the line starting with
#only if it is not the first line.