Draft
Conversation
WalkthroughRemoved the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHubActions as CI
participant TestJob as test-nodes-lib
rect rgba(200,240,255,0.4)
Developer->>CI: push commit (workflow updated)
end
alt Before change
CI->>TestJob: skip (if: false) %%#0066cc
Note right of TestJob: job not executed
else After change
CI->>TestJob: enqueue & run %%#00aa55
TestJob->>CI: report results
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current test configuration collides with the same ports used in the local dev backend, not allowing you to run tests simultaneously whilst still having the local dev backend running. These changes are an attempt at fixing that issue, however there's a problem with ceramic reads not working, as indicated by the nodes-lib tests failing due to a timeout.
Useful info:
:5101 C1 used for ceramic writes
:5102 FlightSQL client used for ceramic reads
Main changes in docker-compose.test.yml, and integrationTestRunner.sh, GH not showing the diffs in this PR