Skip to content

WIP: Port shifted test configuration#1151

Draft
kadamidev wants to merge 2 commits intodevelopfrom
fix-nodes-lib-tests
Draft

WIP: Port shifted test configuration#1151
kadamidev wants to merge 2 commits intodevelopfrom
fix-nodes-lib-tests

Conversation

@kadamidev
Copy link
Copy Markdown
Contributor

@kadamidev kadamidev commented Oct 24, 2025

The current test configuration collides with the same ports used in the local dev backend, not allowing you to run tests simultaneously whilst still having the local dev backend running. These changes are an attempt at fixing that issue, however there's a problem with ceramic reads not working, as indicated by the nodes-lib tests failing due to a timeout.

Useful info:
:5101 C1 used for ceramic writes
:5102 FlightSQL client used for ceramic reads

Main changes in docker-compose.test.yml, and integrationTestRunner.sh, GH not showing the diffs in this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 24, 2025

Walkthrough

Removed the if: false conditional that prevented the test-nodes-lib job from running in the GitHub Actions workflow, and renamed environment variable CERAMIC_ONE_FLIGHT_URL to CERAMIC_FLIGHT_URL in two services within docker-compose.test.yml.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
\.github/workflows/nodes-lib-build-and-test.yaml
Removed if: false from the test-nodes-lib job, enabling the job to run in CI.
Docker Compose (test)
docker-compose.test.yml
Renamed environment variable CERAMIC_ONE_FLIGHT_URLCERAMIC_FLIGHT_URL for services dpid_resolver_test and nodes_lib_test (value/host unchanged).

Sequence Diagram(s)

sequenceDiagram
  participant Developer
  participant GitHubActions as CI
  participant TestJob as test-nodes-lib

  rect rgba(200,240,255,0.4)
    Developer->>CI: push commit (workflow updated)
  end

  alt Before change
    CI->>TestJob: skip (if: false)  %%#0066cc
    Note right of TestJob: job not executed
  else After change
    CI->>TestJob: enqueue & run       %%#00aa55
    TestJob->>CI: report results
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Review points: ensure the renamed env var is consumed by tests/containers as expected; verify no other references to CERAMIC_ONE_FLIGHT_URL remain.

Possibly related PRs

  • Cron email sys #1149 — Renames CERAMIC_* env variable in docker-compose.test.yml; likely touches the same test configuration and variable naming.

Poem

🐰 I nudged a slumbering test to rise,
A URL renamed beneath moonlit skies,
CI hums, containers stir and run,
Little hops of green when checks are done. 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title Check ⚠️ Warning The pull request title "WIP: Port shifted test configuration" is vague and misleading. The term "Port shifted" suggests modifications to port numbers or port-related configurations, but the actual changes involve enabling a previously disabled test job in the workflow and renaming environment variables from CERAMIC_ONE_FLIGHT_URL to CERAMIC_FLIGHT_URL. Neither of these changes involves shifting ports. A teammate scanning the commit history would not clearly understand what was changed based on this title alone, as it fails to convey the primary objectives of enabling the test job or renaming configuration variables. Consider revising the title to more accurately describe the changes, such as "Enable nodes-lib test workflow and update environment variable names" or "Rename environment variables and enable test-nodes-lib job in workflow". This would clearly communicate the main changes without misleading terminology and help reviewers and future maintainers quickly understand what the PR accomplishes.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-nodes-lib-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kadamidev kadamidev changed the title Nodes lib tests WIP: Port shifted test configuration Oct 27, 2025
@kadamidev kadamidev marked this pull request as draft October 27, 2025 06:25
@kadamidev kadamidev changed the base branch from develop to main October 27, 2025 06:29
@kadamidev kadamidev changed the base branch from main to develop October 27, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant