Skip to content

Fix ORCID wallet duplicate message grammar#997

Open
hubsmoke wants to merge 1 commit intodevelopfrom
codex/update-error-message-in-associatewallet.ts
Open

Fix ORCID wallet duplicate message grammar#997
hubsmoke wants to merge 1 commit intodevelopfrom
codex/update-error-message-in-associatewallet.ts

Conversation

@hubsmoke
Copy link
Copy Markdown
Member

@hubsmoke hubsmoke commented Jun 3, 2025

Summary

  • fix grammar in ORCID wallet association error message

Testing

  • yarn test (fails: package missing from lockfile)

https://chatgpt.com/codex/tasks/task_b_683ed19a7e7883209c7349f76302b574

Summary by CodeRabbit

  • Bug Fixes
    • Improved the clarity of the error message shown when an ORCID DID is already registered to another user.

@hubsmoke hubsmoke added the codex Protocol-related improvements label Jun 3, 2025 — with ChatGPT Codex Connector
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jun 3, 2025

Walkthrough

The change updates the error message in the user wallet association controller. When an ORCID DID is already linked to a different user, the returned message is now clearer and more descriptive. No other logic, status codes, or exported entities were altered.

Changes

File Change Summary
desci-server/src/controllers/users/associateWallet.ts Updated error message for existing ORCID DID association

Poem

A message once unclear, now shines so bright,
For wallets and DIDs, we set it right.
No confusion left for users to see—
The error now speaks with clarity!
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
desci-server/src/controllers/users/associateWallet.ts (1)

64-66: Unify error response keys for consistency.
In the earlier check for an existing ORCID on the same user you use { message: ... }, but here you return { err: ... }. Consider standardizing on a single property (e.g., message) across all error responses to avoid confusion for API clients.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db524ce and bba75ad.

📒 Files selected for processing (1)
  • desci-server/src/controllers/users/associateWallet.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build-and-test
🔇 Additional comments (1)
desci-server/src/controllers/users/associateWallet.ts (1)

64-66: Grammar fix is spot on.
The updated error message "orcid DID already registered to another user" reads clearly and correctly conveys the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex Protocol-related improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant