Skip to content

Add timeout to generate embedded link and allow create link for signup#310

Merged
slavikm merged 4 commits intomainfrom
generate-embedded-timeout
Apr 3, 2026
Merged

Add timeout to generate embedded link and allow create link for signup#310
slavikm merged 4 commits intomainfrom
generate-embedded-timeout

Conversation

@slavikm
Copy link
Copy Markdown
Member

@slavikm slavikm commented Apr 3, 2026

Related Issues

Fixes https://github.com/descope/etc/issues/14907

Description

Added the following changes:

  1. Timeout to generateEmbeddedLink
  2. New API to generate a sign-up embedded link - generateSignUpEmbeddedLink
  3. locale and templateId to LoginOptions
  4. Bump version

Must

  • Tests
  • Documentation (if applicable)

Copilot AI review requested due to automatic review settings April 3, 2026 20:27
@shuni-bot-dev
Copy link
Copy Markdown

shuni-bot-dev bot commented Apr 3, 2026

🐕 Review complete — View session on Shuni Portal 🐾

Copy link
Copy Markdown

@shuni-bot-dev shuni-bot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni's Review

Adds timeout to generateEmbeddedLink, a new generateSignUpEmbeddedLink API, and locale/templateId fields to LoginOptions.

Sniffed out 2 issues:

  • 1 🔴 CRITICAL: missing GenerateSignUpEmbeddedLinkRequest class — project won't compile
  • 1 🟡 MEDIUM: breaking change to public interface generateEmbeddedLink with no backward-compatible overload

This one needs a bath! Woof!

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for expiring embedded-link tokens via a timeout parameter and introduces a new management API to generate sign-up embedded links, alongside extending LoginOptions and bumping the SDK version.

Changes:

  • Add timeout (seconds) to generateEmbeddedLink and request payload.
  • Add generateSignUpEmbeddedLink API and corresponding management route.
  • Extend LoginOptions with locale and templateId; bump version to 1.0.64.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/test/java/com/descope/sdk/mgmt/impl/UserServiceImplTest.java Updates embedded link tests for new timeout signature and adds coverage for sign-up embedded link.
src/main/java/com/descope/sdk/mgmt/UserService.java Updates management service interface: timeout added and new sign-up embedded link method introduced.
src/main/java/com/descope/sdk/mgmt/impl/UserServiceImpl.java Implements timeout support and adds sign-up embedded link call + route composition.
src/main/java/com/descope/model/user/request/GenerateEmbeddedLinkRequest.java Adds timeout to the request model.
src/main/java/com/descope/model/magiclink/LoginOptions.java Adds locale and templateId fields.
src/main/java/com/descope/literals/Routes.java Adds new management endpoint for sign-up embedded link generation.
pom.xml Version bump to 1.0.64.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@slavikm slavikm requested a review from Copilot April 3, 2026 20:35
@slavikm slavikm enabled auto-merge (squash) April 3, 2026 20:35
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@slavikm slavikm requested a review from gshriki April 3, 2026 21:15
@slavikm slavikm merged commit a7c3bc0 into main Apr 3, 2026
17 checks passed
@slavikm slavikm deleted the generate-embedded-timeout branch April 3, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants