Add timeout to generate embedded link and allow create link for signup#310
Add timeout to generate embedded link and allow create link for signup#310
Conversation
|
🐕 Review complete — View session on Shuni Portal 🐾 |
There was a problem hiding this comment.
🐕 Shuni's Review
Adds timeout to generateEmbeddedLink, a new generateSignUpEmbeddedLink API, and locale/templateId fields to LoginOptions.
Sniffed out 2 issues:
- 1 🔴 CRITICAL: missing
GenerateSignUpEmbeddedLinkRequestclass — project won't compile - 1 🟡 MEDIUM: breaking change to public interface
generateEmbeddedLinkwith no backward-compatible overload
This one needs a bath! Woof!
There was a problem hiding this comment.
Pull request overview
Adds support for expiring embedded-link tokens via a timeout parameter and introduces a new management API to generate sign-up embedded links, alongside extending LoginOptions and bumping the SDK version.
Changes:
- Add
timeout(seconds) togenerateEmbeddedLinkand request payload. - Add
generateSignUpEmbeddedLinkAPI and corresponding management route. - Extend
LoginOptionswithlocaleandtemplateId; bump version to1.0.64.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/test/java/com/descope/sdk/mgmt/impl/UserServiceImplTest.java |
Updates embedded link tests for new timeout signature and adds coverage for sign-up embedded link. |
src/main/java/com/descope/sdk/mgmt/UserService.java |
Updates management service interface: timeout added and new sign-up embedded link method introduced. |
src/main/java/com/descope/sdk/mgmt/impl/UserServiceImpl.java |
Implements timeout support and adds sign-up embedded link call + route composition. |
src/main/java/com/descope/model/user/request/GenerateEmbeddedLinkRequest.java |
Adds timeout to the request model. |
src/main/java/com/descope/model/magiclink/LoginOptions.java |
Adds locale and templateId fields. |
src/main/java/com/descope/literals/Routes.java |
Adds new management endpoint for sign-up embedded link generation. |
pom.xml |
Version bump to 1.0.64. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Related Issues
Fixes https://github.com/descope/etc/issues/14907
Description
Added the following changes:
generateEmbeddedLinkgenerateSignUpEmbeddedLinklocaleandtemplateIdto LoginOptionsMust