Skip to content

test windows compiler warnings #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: mbf/prebuild
Choose a base branch
from
Open

test windows compiler warnings #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions .github/workflows/prebuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,27 +37,22 @@ jobs:
run: brew install nasm pkg-config
if: ${{ runner.os == 'macOS'}}

- name: install Mac dependencies (shared release)
- name: install ffmpeg dependencies (shared release)
run: node ./install_ffmpeg.js
if: ${{ runner.os == 'macOS'}}

- name: install Windows dependencies
run: node ./install_ffmpeg.js
if: ${{ runner.os == 'Windows'}}

- name: prebuild for macOS (x64)
run: npx prebuild --runtime napi --arch x64 --include-regex '(\.node|\.dylib|ffmpeg|ffprobe)$' --upload ${{ secrets.GITHUB_TOKEN }}
if: ${{ runner.os == 'macOS'}}
# - name: prebuild for macOS (x64)
# run: npx prebuild --runtime napi --arch x64 --include-regex '(\.node|\.dylib|ffmpeg|ffprobe)$' --upload ${{ secrets.GITHUB_TOKEN }}
# if: ${{ runner.os == 'macOS'}}

# - name: prebuild for macOS (arm64)
# run: npx prebuild --runtime napi --arch arm64 --include-regex '(\.node|\.dylib|ffmpeg|ffprobe)$' --upload ${{ secrets.GITHUB_TOKEN }}
# if: ${{ runner.os == 'macOS'}}

- name: prebuild for Windows
run: npx prebuild --runtime napi --include-regex '"(\.node|\.dll|ffmpeg\.exe|ffprobe\.exe)$"' --upload ${{ secrets.GITHUB_TOKEN }}
run: npx prebuild --runtime napi --include-regex '"(\.node|\.dll|ffmpeg\.exe|ffprobe\.exe)$"'
shell: bash
if: ${{ runner.os == 'Windows'}}

- name: prebuild for Linux
run: npx prebuild --runtime napi --include-regex '(\.node|\.dylib|ffmpeg|ffprobe)$' --upload ${{ secrets.GITHUB_TOKEN }}
if: ${{ runner.os == 'Linux'}}
# - name: prebuild for Linux
# run: npx prebuild --runtime napi --include-regex '(\.node|\.dylib|ffmpeg|ffprobe)$' --upload ${{ secrets.GITHUB_TOKEN }}
# if: ${{ runner.os == 'Linux'}}
8 changes: 5 additions & 3 deletions binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,14 @@
}
],
['OS=="win"', {
"cflags_cc": [
"/WX"
],
"configurations": {
"Release": {
"msvs_settings": {
"VCCLCompilerTool": {
"RuntimeTypeInfo": "true",
"AdditionalOptions": ['/WX']
"RuntimeTypeInfo": "true"
}
}
}
Expand Down Expand Up @@ -128,7 +130,7 @@
"ffmpeg/ffmpeg-4.3-win64-shared/bin/avutil-56.dll",
"ffmpeg/ffmpeg-4.3-win64-shared/bin/postproc-55.dll",
"ffmpeg/ffmpeg-4.3-win64-shared/bin/swresample-3.dll",
"ffmpeg/ffmpeg-4.3-win64-shared/bin/swscale-5.dll",
"ffmpeg/ffmpeg-4.3-win64-shared/bin/swscale-5.dll"
"node_modules/ffmpeg-ffprobe-static/ffmpeg.exe",
"node_modules/ffmpeg-ffprobe-static/ffprobe.exe",
]
Expand Down