Skip to content

REQUIRE_JEMALLOC and USE_RNNOISE switches #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

REQUIRE_JEMALLOC and USE_RNNOISE switches #112

wants to merge 2 commits into from

Conversation

@mymedia2
Copy link
Contributor

@mymedia2 mymedia2 commented Jul 29, 2021

This was referenced Jul 29, 2021
Open
Closed
@ilya-fedin
Copy link
Contributor

ilya-fedin commented Jul 29, 2021

cmake_helpers has variables like DESKTOP_APP_DISABLE_*, not REQUIRE or USE

@mymedia2
New DESKTOP_APP_REQUIRE_JEMALLOC switch
a23f714 
Do not require jemalloc at runtime, allow one to use system memory allocator.
@mymedia2
New DESKTOP_APP_USE_RNNOISE switch
e3b3322 
RNNoise comes with an ML model trained using closed data. That's unacceptable
in most Linux distributions due to legal issues.

See discussion on Debian bug tracker: https://bugs.debian.org/980839#17
@mymedia2
Copy link
Contributor Author

mymedia2 commented Jan 18, 2022

@ilya-fedin The USE_RNNOISE switch follows the same named macro in the tgcalls subproject.

https://github.com/TelegramMessenger/tgcalls/blob/e9f9aee3a36e1629632350123e6b202ec4f29bfe/tgcalls/group/GroupInstanceCustomImpl.cpp#L58

@klemensn
Copy link
Contributor

klemensn commented Feb 26, 2022

See #183.

@Isabelnadal
Copy link

Isabelnadal commented Mar 16, 2022

cmake_helpers tiene variables como DESKTOP_APP_DISABLE_*, no REQUIERE o USE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Originalmenace Originalmenace Originalmenace approved these changes

@yasid-ai yasid-ai yasid-ai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mymedia2 @ilya-fedin @klemensn @Isabelnadal @Originalmenace @yasid-ai