Fix error logging with default engine configuration #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, configuration values for `log_errors` and `display_errors` depend on how PHP has been configured, and need to be made consistent in order for functionality to conform to expectations. Additionally, the list of errors handled has been expanded to `E_ALL` instead of whatever the default value is.
This commit fixes long-standing issues with comparing floating-point numbers bound into PHP with their original numbers in Go, where issues with imprecise storage may cause errors to occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, configuration values for
log_errorsanddisplay_errorsdepend on how PHP has beenconfigured, and need to be made consistent in order for functionality to conform to expectations.
Additionally, the list of errors handled has been expanded to
E_ALLinstead of whatever thedefault value is.