Add the op_halt patch for Lua 5.4.4 #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfperusse
commented
Apr 18, 2023
lua-5.4.4-op_halt/src/lvm.c
Outdated
| /* LUA_HALT { */ | ||
| // note: duplicated in ldo.c due to dependency tangle (below requires lopcodes.h and lobject.h) | ||
| #define GET_REAL_INSTR(i,p) (GET_OPCODE(i) == OP_HALT ? (p->halts[GETARG_Bx(i)].orig) : (i)) | ||
| #define vmfetchResume() { \ |
There was a problem hiding this comment.
I'm seeing random cases where stepping after a halt does not resume properly, as if it ends up offset. This will require further investigation.
jfperusse
commented
Sep 3, 2023
lua-5.4.4-op_halt/src/ldump.c
Outdated
| dumpByte(D, f->numparams); | ||
| dumpByte(D, f->is_vararg); | ||
| dumpByte(D, f->maxstacksize); | ||
| dumpCode(D, f); |
There was a problem hiding this comment.
This is an issue with the patch and the code ends up being dumped twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the op_halt patch updated for Lua 5.4.4.
It was tested successfully with vscode-debuggee.lua.
We could confirm the performance gain and that breakpoints and stepping through the code is working fine.