feat(download): Enhance artifact extraction with native Go support for skipping symbolic links#150
feat(download): Enhance artifact extraction with native Go support for skipping symbolic links#150beyondkmp wants to merge 2 commits intodevelar:masterfrom
Conversation
…r skipping symbolic links
🦋 Changeset detectedLatest commit: 6042715 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I like this change. But curious question. What if we were to split up the zip artifact so that it's downloaded per-platform? e.g., windows zip doesn't have symbolic links, only the mac zip artifact would. Context: |
I agree with this approach; it should be the most perfect solution. |
fix electron-userland/electron-builder#8149
If the extraction fails,and if it is on Windows and the issue is that symbolic link files cannot be created,simply use the 7zip library in Go to extract again and filter out such files.
Such a modification won't affect previous extractions; it will only solve the problem of wincodesign tools failing during extraction on Windows.