Skip to content

feat: adding env var for "dirname" to mirror the logic in electron-builder #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmaietta merged 1 commit into from
Apr 23, 2025
Merged

feat: adding env var for "dirname" to mirror the logic in electron-builder #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/soft-doors-play.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"app-builder-bin": minor
---

feat: adding env var for "dirname" to mirror the logic in electron-builder
19 changes: 18 additions & 1 deletion pkg/download/tool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func DownloadWinCodeSign() (string, error) {

func downloadFromGithub(name string, version string, checksum string) (string, error) {
id := name + "-" + version
return DownloadArtifact(id, GetGithubBaseUrl()+id+"/"+id+".7z", checksum)
return DownloadArtifact(id, GetGithubBaseUrl()+GetGithubReleaseUrl(id)+"/"+id+".7z", checksum)
}

func GetGithubBaseUrl() string {
Expand All @@ -80,6 +80,23 @@ func GetGithubBaseUrl() string {
return v
}

func GetGithubReleaseUrl(defaultName string) string {
v := os.Getenv("NPM_CONFIG_ELECTRON_BUILDER_BINARIES_CUSTOM_DIR")
if len(v) == 0 {
v = os.Getenv("npm_config_electron_builder_binaries_custom_dir")
}
if len(v) == 0 {
v = os.Getenv("npm_package_config_electron_builder_binaries_custom_dir")
}
if len(v) == 0 {
v = os.Getenv("ELECTRON_BUILDER_BINARIES_CUSTOM_DIR")
}
if len(v) == 0 {
v = defaultName
}
return v
}

func DownloadTool(descriptor ToolDescriptor, osName util.OsName) (string, error) {
arch := runtime.GOARCH
switch arch {
Expand Down
Loading