Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nice-houses-approve.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"app-builder-bin": patch
---

fix(appimage): AppImage fails if fileAssociations.ext is array
23 changes: 17 additions & 6 deletions pkg/package-format/appimage/appLauncher.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ import (
"time"

"github.com/develar/app-builder/pkg/fs"
"github.com/develar/app-builder/pkg/package-format"
package_format "github.com/develar/app-builder/pkg/package-format"
"github.com/develar/app-builder/pkg/util"
"github.com/develar/errors"
"github.com/develar/go-fs-util"
fsutil "github.com/develar/go-fs-util"
)

const iconDirRelativePath = "usr/share/icons/hicolor"
Expand Down Expand Up @@ -126,12 +126,23 @@ func copyMimeTypes(options *AppImageOptions) (string, error) {
mimeTypes.WriteString(options.configuration.ProductName)
mimeTypes.WriteString(" document</comment>\n")

mimeTypes.WriteString(" <glob pattern=\"*.")
mimeTypes.WriteString(fileAssociation.Ext)
mimeTypes.WriteString("\"/>\n")
switch exts := fileAssociation.Ext.(type) {
case string:
mimeTypes.WriteString(" <glob pattern=\"*.")
mimeTypes.WriteString(exts)
mimeTypes.WriteString("\"/>\n")
case []string:
for _, ext := range exts {
mimeTypes.WriteString(" <glob pattern=\"*.")
mimeTypes.WriteString(ext)
mimeTypes.WriteString("\"/>\n")
}
default:
err := fmt.Errorf("unsupported extension type (%T) for MIME type: %s", fileAssociation.Ext, fileAssociation.MimeType)
util.LogErrorAndExit(err)
}

mimeTypes.WriteString(" <generic-icon name=\"x-office-document\"/>\n")

mimeTypes.WriteString("</mime-type>\n")
}
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/package-format/appimage/configuration.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ type IconInfo struct {
}

type FileAssociation struct {
Ext string `json:"ext"`
MimeType string `json:"mimeType"`
Ext interface{} `json:"ext"` // Can be string or []string
MimeType string `json:"mimeType"`
}
Loading