fix: searching outside folder unnecessarily#91
Open
Julusian wants to merge 3 commits intodevelar:masterfrom
Open
fix: searching outside folder unnecessarily#91Julusian wants to merge 3 commits intodevelar:masterfrom
Julusian wants to merge 3 commits intodevelar:masterfrom
Conversation
mmaietta
reviewed
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found an issue where an electron project which happened to be inside another nodejs project was bundling dependencies from the parent directory unnecessarily electron-userland/electron-builder#7745
This appears to be happening because
resolveDependencycan return nil when either the dependency is unresolved, or when the dependency has already been resolved. Dependencies which had already been resolved were then being re-resolved with the correct path to them being rejected, which resulted in it looking in the parent directory for this 'unresolved' dependency, causing my issueThis is not the prettiest solution, but as this repository appears unmaintained, I expect this will only serve as a reference for others