Conversation
ciaransweet
reviewed
Jan 30, 2026
Comment on lines
22
to
25
| @field_validator("DRY_RUN", "DEBUG", mode="before") | ||
| @classmethod | ||
| def _parse_bool(cls, v: str | bool) -> bool: | ||
| return v if isinstance(v, bool) else v.lower() == "true" |
There was a problem hiding this comment.
Just noticed this - afaik Pydantic is pretty forgiving with converting strings to bools. Basically any form of "true" in a string, and 1 and yes are set to True if a field is a bool. I don't think we need this parsing.
Contributor
Author
There was a problem hiding this comment.
Good catch. Removed it.
ciaransweet
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.