fix: skip inferRenderPipeline when user provides custom getTileData/renderTile#260
Open
james-willis wants to merge 1 commit intodevelopmentseed:mainfrom
Conversation
james-willis
force-pushed
the
fix/skip-infer-render-pipeline-with-custom-props
branch
from
050d9b4 to
fef2fa6
Compare
…enderTile inferRenderPipeline() only supports unsigned integer SampleFormats and throws for Float32/Int COGs, even when the user provides both getTileData and renderTile props (making the inferred defaults unused). Fixes developmentseed#257
james-willis
force-pushed
the
fix/skip-infer-render-pipeline-with-custom-props
branch
from
fef2fa6 to
a8ad44a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COGLayer._parseGeoTIFF()unconditionally callsinferRenderPipeline(), which throws for non-uintSampleFormat(e.g. Float32, Int), even when the user provides bothgetTileDataandrenderTilepropsProblem
When using
COGLayerwith a Float32 COG and customgetTileData/renderTile:There's no workaround — the user has no way to use
COGLayerwith non-uint COGs, even with fully custom rendering.Fix
Guard
inferRenderPipeline()behind a check for user-provided props. No behavior change for the default case (when either callback is missing, inference still runs as before).Fixes #257