Copy masked array to a new array rather than replacing in place#71
Merged
vincentsarago merged 2 commits intodevelopmentseed:mainfrom Sep 9, 2025
Merged
Copy masked array to a new array rather than replacing in place#71vincentsarago merged 2 commits intodevelopmentseed:mainfrom
vincentsarago merged 2 commits intodevelopmentseed:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I am changing
Copy masked array in
_get_statsrather than replacing it in place to avoid the subtle difference in behavior withcopy=FalseThis causes the subsequent computation like
.max()take that fill value in account.How you can test it
Run
_get_statswith the file attached in the issue below.It now gives the correct max value.
Related Issues
#70