Skip to content

Conversation

@rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jun 18, 2025

Description of Changes

  • Update sigs.k8s.io/controller-runtime to latest available version v0.22.1
  • Update sigs.k8s.io/controller-tools to v0.19.0
    • support for v1beta1 CRDs has been removed
    • ctx.WriteYAML now requires additional headerText argument, I've added the content of license_header.txt. Let me know if we want to keep it without header.
  • Update Go version to 1.24 (required for controller runtime)

Signed-off-by: Rohan Kumar rohaan@redhat.com

Related Issue(s)

This is related to a synk issue, We would like to update apiextensions-apiserver dependency to >= v0.33.1 . This also requires bumping controller-runtime to the latest version.

Acceptance Criteria

Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.

New testing and documentation issues can be opened under devfile/api/issues.

You can check the respective criteria below if either of the following is true:

  • There is a separate tracking issue opened and that issue is linked in this PR.
  • Testing/documentation updates are contained within this PR.

If criteria is left unchecked please provide an explanation why.

Tests Performed

I ran the tests mentioned in CONTRIBUTING guide:

# schemaTest approach
cd test/v200/schemaTest
go test -v

# apiTest approach
cd test/v200/apiTest
go test -v

@openshift-ci
Copy link

openshift-ci bot commented Jun 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohanKanojia

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rohanKanojia rohanKanojia force-pushed the pr/bump-controller-runtime-post-0-21-0 branch from 580a483 to 8d4841a Compare June 18, 2025 11:05
…v0.21.1-0.20250617162058-15c5d6129278

- Update sigs.k8s.io/controller-runtime to latest available version
- Update sigs.k8s.io/controller-tools to v0.18.0
  - support for v1beta1 CRDs has been removed
- Update Go version to 1.24 (required for controller runtime)

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
… update

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia force-pushed the pr/bump-controller-runtime-post-0-21-0 branch from d426069 to 74446e9 Compare September 9, 2025 09:52
@rohanKanojia rohanKanojia changed the title chore (deps) : Update Controller runtime to latest available version v0.21.1-0.20250617162058-15c5d6129278 chore (deps) : Update Controller runtime to v0.22.1 Sep 9, 2025
@rohanKanojia rohanKanojia marked this pull request as ready for review September 9, 2025 10:15
@rohanKanojia rohanKanojia requested review from a team, AObuchow and dkwon17 as code owners September 9, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants