Conversation
SwiftLint found issuesWarnings
Errors
Generated by 🚫 Danger |
Member
|
@copilot remove sourceLocation lines from generated Swift file. |
Copilot
AI
changed the title
[WIP] Fix incorrect Apple Pencil compatibility for iPad models
Fix Apple Pencil compatibility for M4 iPad Pro and M2/M3 iPad Air models
Nov 17, 2025
Contributor
Author
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect Apple Pencil compatibility information for recent iPad models by updating the applePencilSupport property to match Apple's official documentation. The changes correct compatibility for M4 iPad Pro, M2/M3 iPad Air, and 10th generation iPad models.
Key changes:
- Added template support for the value 13 combination (1st gen + USB-C Pencil) in the code generation template
- Updated 8 iPad models with corrected Apple Pencil support values
- Added comprehensive test coverage for all affected devices
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Source/Device.swift.gyb | Updated applePencilSupport values for 8 iPad models (iPad 10th gen, iPad A16, 4 iPad Air models, 2 iPad Pro M4 models) and added template case for value 13 |
| Source/Device.generated.swift | Regenerated Swift code from template with corrected Apple Pencil support arrays for all affected devices |
| Tests/Tests.swift | Added testApplePencilSupport() function with 50 lines of assertions validating correct Pencil support for all 8 affected iPad models |
Member
|
@copilot Please add a changelog entry and fix linting errors from swiftlint on the lines you changed. Don't apply linting fixes to lines that you haven't touched previously inside this PR. |
Contributor
Author
Zandor300
force-pushed
the
copilot/fix-apple-pencil-compatibility
branch
from
9b4a20f to
ff78b6e
Compare
Member
|
@copilot You need to rebase on master. |
Contributor
Author
I'm unable to perform a rebase as it requires force push, which I don't have access to. Could you please rebase this branch on master? Once done, I can continue with any additional changes needed. |
Zandor300
force-pushed
the
copilot/fix-apple-pencil-compatibility
branch
from
4ed1389 to
a50c628
Compare
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
The firstGenerationUsbC raw value (0x03) overlapped with firstGeneration (0x01) and secondGeneration (0x02), causing contains() checks to return incorrect results. Changed to proper power-of-2 values. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Zandor300
force-pushed
the
copilot/fix-apple-pencil-compatibility
branch
from
46fce1b to
a43c030
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| /// | ||
| /// - returns: An initialized `Device`. | ||
| public static func mapToDevice(identifier: String) -> Device { // swiftlint:disable:this cyclomatic_complexity function_body_length | ||
| public static func mapToDevice(identifier: String) -> Device { |
There was a problem hiding this comment.
Function should have complexity 10 or less: currently complexity equals 140cyclomatic_complexity Device.generated.swift:626 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect Apple Pencil compatibility for recent iPad models
Based on Apple's official documentation at https://support.apple.com/en-au/HT211029:
Changes Summary:
✅ iPad (10th gen) & iPad (A16)
✅ iPad Air 11" & 13" (M2)
✅ iPad Air 11" & 13" (M3)
✅ iPad Pro 11" & 13" (M4)
Technical Changes:
Files Changed:
Source/Device.swift.gyb- Updated device definitions and added template case for value 13Source/Device.generated.swift- Regenerated from template without sourceLocation linesTests/Tests.swift- Added tests validating all changesCHANGELOG.md- Added bug fix entryNote: This project requires macOS with Xcode to build and test. The CI pipeline will validate these changes on macOS.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.